Resource freed twice on error

Code reviewCode quality & reviewSenior–Staff~30 min

Review this C resource-cleanup path.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 30 min

Mark a line and say what kind of problem it is.0 findings

1#include <stdlib.h>

3int load(const char *path, char **out) {

4 char *buf = malloc(1024);

5 if (!buf) return -1;

6 if (read_file(path, buf, 1024) < 0) {

7 free(buf);

8 goto fail;

9 }

10 *out = buf;

11 return 0;

12fail:

13 free(buf);

14 return -1;

15}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.