Code reviewHardcr-g163

Subject Dangling pointerLevel Senior–Staff~30 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this C++ code using std::string_view.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1#include <string>2#include <string_view>3 4std::string make_name(int id) {5    return "user-" + std::to_string(id);6}7 8void run(int id) {9    std::string_view sv = make_name(id);10    // ... later ...11    process(sv);   // takes std::string_view12}

Run or narrate your approach, then ask the coach.