Code reviewMediumcr-g164

Subject Iterator invalidationLevel Mid–Senior~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ range-for that duplicates flagged items.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1#include <vector>2 3struct Item { int id; bool flagged; };4 5void expand(std::vector<Item>& items) {6    for (const Item& it : items) {7        if (it.flagged) {8            items.push_back(Item{ it.id + 1000, false });9        }10    }11}

Run or narrate your approach, then ask the coach.