Code reviewHardcr-g167

Subject Use after freeLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ async registration using a lambda.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1#include <functional>2#include <string>3 4struct Worker {5    std::string name;6    void schedule(std::function<void()>& slot) {7        slot = [this]() { use(name); };8    }9    void use(const std::string& s);10};11 12std::function<void()> g_slot;13void wire() {14    std::function<void()> tmp;15    { Worker w{"alpha"}; w.schedule(reinterpret_cast<std::function<void()>&>(tmp)); }16    g_slot = tmp;17    g_slot();   // invoked later18}

Run or narrate your approach, then ask the coach.