Code reviewMediumcr-g169

Subject LifetimesLevel Mid–Senior~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ code that stores pointers to loop-local objects.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1#include <vector>2#include <string>3 4std::vector<const std::string*> collect(const std::vector<int>& ids) {5    std::vector<const std::string*> out;6    for (int id : ids) {7        std::string label = "id-" + std::to_string(id);8        out.push_back(&label);9    }10    return out;11}

Run or narrate your approach, then ask the coach.