Code RoomPointers to loop variables

MediumPrep Room Coding #1804

Pointers to loop variables

Code reviewCode quality & reviewMid–Senior~25 min

Review this C++ code that stores pointers to loop-local objects.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1#include <vector>

2#include <string>

3

4std::vector<const std::string*> collect(const std::vector<int>& ids) {

5 std::vector<const std::string*> out;

6 for (int id : ids) {

7 std::string label = "id-" + std::to_string(id);

8 out.push_back(&label);

9 }

10 return out;

11}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.