Code reviewHardcr-g171

Subject Use after freeLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C dynamic-array append.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewc

1#include <stdlib.h>2 3typedef struct { int *data; size_t len, cap; } Vec;4 5int *vec_push(Vec *v, int value) {6    if (v->len == v->cap) {7        v->cap = v->cap ? v->cap * 2 : 4;8        v->data = realloc(v->data, v->cap * sizeof(int));9    }10    v->data[v->len] = value;11    return &v->data[v->len++];12}

Run or narrate your approach, then ask the coach.