Code reviewHardcr-g172

Subject Iterator invalidationLevel Senior–Staff~30 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this C++ code holding a reference across map inserts.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1#include <unordered_map>2#include <string>3 4void build(std::unordered_map<int, std::string>& m) {5    std::string& slot = m[1];6    slot = "one";7    for (int i = 2; i < 100000; ++i) {8        m[i] = std::to_string(i);9    }10    slot += "-final";11}

Run or narrate your approach, then ask the coach.