Code reviewMediumcr-g176

Subject Effect dependenciesLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this React TypeScript component.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewtsx

1function UserProfile({ userId }: { userId: string }) {2  const [user, setUser] = useState<User | null>(null);3 4  useEffect(() => {5    fetch(`/api/users/${userId}`)6      .then((r) => r.json())7      .then(setUser);8  }, []);9 10  if (!user) return <Spinner />;11  return <div>{user.name}</div>;12}

Run or narrate your approach, then ask the coach.