Code RoomEffect skips userId change
MediumPrep Room Coding #1811

Effect skips userId change

Code reviewCode quality & reviewMid–Senior~20 min

Review this React TypeScript component.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1function UserProfile({ userId }: { userId: string }) {
2 const [user, setUser] = useState<User | null>(null);
3 
4 useEffect(() => {
5 fetch(`/api/users/${userId}`)
6 .then((r) => r.json())
7 .then(setUser);
8 }, []);
9 
10 if (!user) return <Spinner />;
11 return <div>{user.name}</div>;
12}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.