Code reviewHardcr-g177

Subject Effect dependenciesLevel Senior–Staff~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this React TypeScript component.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewtsx

1function Chart({ data }: { data: number[] }) {2  const [series, setSeries] = useState<Point[]>([]);3  const options = { smoothing: 0.5, points: data };4 5  useEffect(() => {6    setSeries(computeSeries(options));7  }, [options]);8 9  return <Canvas series={series} />;10}

Run or narrate your approach, then ask the coach.