Options object recreated each render

Code reviewCode quality & reviewSenior–Staff~25 min

Review this React TypeScript component.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1function Chart({ data }: { data: number[] }) {

2 const [series, setSeries] = useState<Point[]>([]);

3 const options = { smoothing: 0.5, points: data };

5 useEffect(() => {

6 setSeries(computeSeries(options));

7 }, [options]);

9 return <Canvas series={series} />;

10}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.