WebSocket handler not cleaned

Code reviewNetworking & APIsSenior–Staff~24 min

Review this React TypeScript hook.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 24 min

Mark a line and say what kind of problem it is.0 findings

1function useLiveFeed(url: string) {

2 const [msgs, setMsgs] = useState<Msg[]>([]);

4 useEffect(() => {

5 const ws = new WebSocket(url);

6 ws.onmessage = (e) => setMsgs((m) => [...m, JSON.parse(e.data)]);

7 return () => ws.onmessage = null;

8 }, [url]);

10 return msgs;

11}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.