Code reviewMediumcr-g205

Subject N plus oneLevel Mid–Senior~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java (JPA/Hibernate) service method.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1@Transactional(readOnly = true)2public List<TeamDto> activeTeams() {3    List<Team> teams = em.createQuery(4        "SELECT t FROM Team t WHERE t.active = true", Team.class)5        .getResultList();6    return teams.stream().map(t -> new TeamDto(7        t.getName(),8        t.getMembers().size(),            // members is @OneToMany(fetch = LAZY)9        t.getLead().getEmail()            // lead is @ManyToOne(fetch = LAZY)10    )).collect(Collectors.toList());11}

Run or narrate your approach, then ask the coach.