Code RoomLost update on concurrent increments

MediumPrep Room Coding #1844

Lost update on concurrent increments

Code reviewCode quality & reviewMid–Senior~20 min

Review this Python (Django) view that increments an article's view counter and updates last-seen.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1def record_view(request, article_id):

2 article = Article.objects.get(pk=article_id)

3 if article.status != "published":

4 return HttpResponse(status=404)

5 article.views = article.views + 1

6 article.last_viewed = timezone.now()

7 article.save()

8 log_view(request.user, article)

9 return HttpResponse(status=204)

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.