Code RoomJournal posts only one side

HardPrep Room Coding #1845

Journal posts only one side

Code reviewDatabases & SQLConcurrencySenior–Staff~28 min

Review this Python (psycopg2) function that posts a double-entry journal.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 28 min

Mark a line and say what kind of problem it is.0 findings

1def post_journal(conn, debit_acct, credit_acct, amount):

2 cur = conn.cursor()

3 cur.execute("UPDATE accounts SET balance = balance - %s WHERE id = %s",

4 (amount, debit_acct))

5 conn.commit()

6 cur.execute("UPDATE accounts SET balance = balance + %s WHERE id = %s",

7 (amount, credit_acct))

8 conn.commit()

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.