Code reviewHardcr-g210

Subject Transaction isolationLevel Senior–Staff~28 minCommon in Databases & SQL · Concurrency interviewsIndustries Software development

Question

Review this Python (psycopg2) function that posts a double-entry journal.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def post_journal(conn, debit_acct, credit_acct, amount):2    cur = conn.cursor()3    cur.execute("UPDATE accounts SET balance = balance - %s WHERE id = %s",4                (amount, debit_acct))5    conn.commit()6    cur.execute("UPDATE accounts SET balance = balance + %s WHERE id = %s",7                (amount, credit_acct))8    conn.commit()

Run or narrate your approach, then ask the coach.