Code reviewMediumcr-g211

Subject Phantom readLevel Mid–Senior~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python (SQLAlchemy) signup handler that enforces unique emails.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def register(session, email, pw_hash):2    existing = session.query(User).filter_by(email=email).first()3    if existing:4        raise EmailTaken(email)5    user = User(email=email, pw_hash=pw_hash)6    session.add(user)7    session.commit()8    return user

Run or narrate your approach, then ask the coach.