Code RoomPhantom read on email uniqueness

MediumPrep Room Coding #1846

Phantom read on email uniqueness

Code reviewCode quality & reviewMid–Senior~22 min

Review this Python (SQLAlchemy) signup handler that enforces unique emails.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min

Mark a line and say what kind of problem it is.0 findings

1def register(session, email, pw_hash):

2 existing = session.query(User).filter_by(email=email).first()

3 if existing:

4 raise EmailTaken(email)

5 user = User(email=email, pw_hash=pw_hash)

6 session.add(user)

7 session.commit()

8 return user

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.