Code reviewHardcr-g216

Subject DeadlockLevel Senior–Staff~30 minCommon in Concurrency interviewsIndustries Software development

Question

Review this Java (JDBC) batch that applies price adjustments to many products in one transaction.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1void applyAdjustments(Connection conn, Map<Long, BigDecimal> deltas) throws SQLException {2    conn.setAutoCommit(false);3    PreparedStatement ps = conn.prepareStatement(4        "UPDATE products SET price = price + ? WHERE id = ?");5    for (Map.Entry<Long, BigDecimal> e : deltas.entrySet()) {6        ps.setBigDecimal(1, e.getValue());7        ps.setLong(2, e.getKey());8        ps.addBatch();9    }10    ps.executeBatch();11    conn.commit();12}

Run or narrate your approach, then ask the coach.