Code RoomBatch update hangs

HardPrep Room Coding #1851

Batch update hangs

Code reviewConcurrencySenior–Staff~30 min

Review this Java (JDBC) batch that applies price adjustments to many products in one transaction.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 30 min

Mark a line and say what kind of problem it is.0 findings

1void applyAdjustments(Connection conn, Map<Long, BigDecimal> deltas) throws SQLException {

2 conn.setAutoCommit(false);

3 PreparedStatement ps = conn.prepareStatement(

4 "UPDATE products SET price = price + ? WHERE id = ?");

5 for (Map.Entry<Long, BigDecimal> e : deltas.entrySet()) {

6 ps.setBigDecimal(1, e.getValue());

7 ps.setLong(2, e.getKey());

8 ps.addBatch();

9 }

10 ps.executeBatch();

11 conn.commit();

12}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.