Code reviewHardcr-g225

Subject Memory orderingLevel Senior–Staff~40 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ publish/consume flag pattern.

The atomic is there so it must be fine, right?

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1int   payload = 0;2std::atomic<bool> ready{false};3 4void producer() {5    payload = compute();                              // (1) plain store6    ready.store(true, std::memory_order_relaxed);     // (2)7}8 9void consumer() {10    while (!ready.load(std::memory_order_relaxed)) {}  // (3) spin11    use(payload);                                      // (4)12}

Run or narrate your approach, then ask the coach.