Prep Room
Sign inCreate account
Code Room
Code reviewMediumcr-g226
Subject Goroutine leaksLevel Mid–Senior~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go background metric flusher.

What resources leak here?

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts
Talk through your review
Code to reviewgo
func StartFlusher(ctx context.Context, m *Metrics) {    ticker := time.NewTicker(5 * time.Second)    go func() {        for {            select {            case <-ticker.C:                m.Flush()            }        }    }()}
Run or narrate your approach, then ask the coach.