Ticker and goroutine never stop
Review this Go background metric flusher.
What resources leak here?
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 25 min
Mark a line and say what kind of problem it is.0 findings
1func StartFlusher(ctx context.Context, m *Metrics) {
2 ticker := time.NewTicker(5 * time.Second)
3 go func() {
4 for {
5 select {
6 case <-ticker.C:
7 m.Flush()
8 }
9 }
10 }()
11}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.