Code RoomInvoice access not authorized
MediumPrep Room Coding #1875

Invoice access not authorized

Code reviewNetworking & APIsMid–Senior~25 min

Review this Express invoice download endpoint.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min
Mark a line and say what kind of problem it is.0 findings
1app.get('/api/invoices/:id/pdf', requireLogin, async (req, res) => {
2 const invoice = await db.invoice.findUnique({
3 where: { id: req.params.id },
4 });
5 if (!invoice) return res.status(404).send('not found');
6 const pdf = await renderInvoicePdf(invoice);
7 res.type('application/pdf').send(pdf);
8});
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.