Code RoomReset token predictable
HardPrep Room Coding #1891

Reset token predictable

Code reviewCode quality & reviewSenior–Staff~30 min

Review this Node.js password-reset token generator.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 30 min
Mark a line and say what kind of problem it is.0 findings
1const crypto = require('crypto');
2 
3function createResetToken(userId) {
4 const seed = Date.now() + ':' + userId;
5 const token = crypto.createHash('md5').update(seed).digest('hex');
6 resets.set(token, { userId, exp: Date.now() + 3600_000 });
7 return token;
8}
9// emailed as https://app/reset?token=<token>
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.