Code reviewHardcr-g269

Subject RoundingLevel Senior–Staff~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java code that splits an invoice total evenly across line items, in cents.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1long[] split(long totalCents, int parts) {2    long[] out = new long[parts];3    long each = (long) (totalCents / (double) parts);4    for (int i = 0; i < parts; i++) {5        out[i] = each;6    }7    return out;8}

Run or narrate your approach, then ask the coach.