Code reviewHardcr-g272

Subject CorrectnessLevel Senior–Staff~18 minCommon in Code quality & review · Algorithms & data structures interviewsIndustries Software development

Question

Review this Java request router that dispatches on an uppercased command keyword.

The service runs in pods whose locale is inherited from the host. QA in the US passes; a customer in Turkey reports that valid `insert`/`index` commands are rejected.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1void dispatch(Request req) {2    String cmd = req.header("X-Command");3    if (cmd == null) {4        reject(req);5        return;6    }7    switch (cmd.toUpperCase()) {8        case "INSERT": doInsert(req); break;9        case "INDEX":  doIndex(req);  break;10        case "DELETE": doDelete(req); break;11        default:       reject(req);12    }13}

Run or narrate your approach, then ask the coach.