Code reviewMediumcr-g284

Subject Inefficient data structureLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python function that filters incoming events to those whose user is on an allowlist. The allowlist is loaded from config and can hold tens of thousands of ids.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def filter_allowed(events, allowlist):2    # allowlist is a list of user_ids loaded from config3    allowed = []4    for e in events:5        if e.user_id in allowlist:6            allowed.append(e)7    return allowed

Run or narrate your approach, then ask the coach.