Code reviewMediumcr-g288

Subject Missing cacheLevel Mid–Senior~18 minCommon in Networking & APIs interviewsIndustries Software development, Technology

Question

Review this Go HTTP handler that returns a customer's audit-log entries. There is no `limit`, and customers with long histories time out.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func auditHandler(w http.ResponseWriter, r *http.Request) {2    cust := r.URL.Query().Get("customer")3    rows, _ := db.Query("SELECT id, action, ts FROM audit WHERE customer=$1 ORDER BY ts DESC", cust)4    defer rows.Close()5    var out []Entry6    for rows.Next() {7        var e Entry8        rows.Scan(&e.ID, &e.Action, &e.Ts)9        out = append(out, e)10    }11    json.NewEncoder(w).Encode(out)12}

Run or narrate your approach, then ask the coach.