Code reviewHardcr-g289

Subject Boxing overheadLevel Senior–Staff~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java method that sums a metric over millions of samples in a tight aggregation loop.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1long sumLatencies(int[] samples) {2    Long total = 0L;3    for (int i = 0; i < samples.length; i++) {4        total += samples[i];5    }6    return total;7}

Run or narrate your approach, then ask the coach.