Code RoomTeam member counts N+1 query

MediumPrep Room Coding #1925

Team member counts N+1 query

Code reviewDatabases & SQLMid–Senior~18 min

Review this JavaScript service that builds a dashboard of teams with their member counts.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1async function teamsWithCounts(orgId) {

2 const teams = await db.query("SELECT id, name FROM teams WHERE org_id = $1", [orgId]);

3 const result = [];

4 for (const t of teams) {

5 const c = await db.query("SELECT COUNT(*) AS n FROM members WHERE team_id = $1", [t.id]);

6 result.push({ ...t, members: c[0].n });

7 }

8 return result;

9}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.