Exchange rate API hammered
Review this Python function that converts amounts using live FX rates. It is called for every line item on every invoice render, and the rates barely change during a day.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1def to_usd(amount, currency):
2 rates = fetch_rates_from_api() # network call, returns dict by currency
3 return amount * rates[currency]
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.