LinkedList index access quadratic
Review this Java method that pairs up adjacent samples from a buffer. The buffer is a `LinkedList` and the method is slow on large inputs.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1List<Pair> pairAdjacent(LinkedList<Integer> buf) {
2 List<Pair> out = new ArrayList<>();
3 for (int i = 0; i + 1 < buf.size(); i++) {
4 out.add(new Pair(buf.get(i), buf.get(i + 1)));
5 }
6 return out;
7}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.