Code reviewMediumcr-g299

Subject N plus one queriesLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go function that checks whether a feature flag is enabled for a tenant. The flags table is large and the function is called on nearly every request.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func flagEnabled(db *sql.DB, tenant, flag string) bool {2    rows, _ := db.Query("SELECT tenant, name, enabled FROM flags")3    defer rows.Close()4    for rows.Next() {5        var t, n string6        var en bool7        rows.Scan(&t, &n, &en)8        if t == tenant && n == flag {9            return en10        }11    }12    return false13}

Run or narrate your approach, then ask the coach.