Code reviewHardcr-g303

Subject Missing cacheLevel Mid–Senior~20 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this Go function that prices a bill of materials by recursively expanding sub-assemblies. Deep trees with shared sub-assemblies are extremely slow.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func cost(part string, bom map[string][]string, price map[string]float64) float64 {2    total := price[part]3    for _, child := range bom[part] {4        total += cost(child, bom, price)5    }6    return total7}

Run or narrate your approach, then ask the coach.