Code reviewHardcr-g304

Subject Retry logicLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go retry helper used by every instance of a fleet to call a shared downstream. It already retries on error.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func fetch(ctx context.Context, url string) (*http.Response, error) {2    var lastErr error3    for i := 0; i < 5; i++ {4        resp, err := http.Get(url)5        if err == nil && resp.StatusCode < 500 {6            return resp, nil7        }8        lastErr = err9        time.Sleep(50 * time.Millisecond)10    }11    return nil, lastErr12}

Run or narrate your approach, then ask the coach.