Code reviewHardcr-g305

Subject Retry logicLevel Senior–Staff~22 minCommon in Networking & APIs interviewsIndustries Software development

Question

Review this Java helper that retries a payment POST on any failure.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1ChargeResult charge(ChargeRequest req) {2    for (int attempt = 0; attempt < 3; attempt++) {3        try {4            HttpResponse<String> r = client.send(post("/charges", req), ofString());5            if (r.statusCode() < 500) return parse(r.body());6        } catch (IOException | InterruptedException e) {7            // network blip — retry8        }9    }10    throw new ChargeException("charge failed");11}

Run or narrate your approach, then ask the coach.