Code reviewHardcr-g310

Subject Timeout handlingLevel Senior–Staff~22 minCommon in Networking & APIs interviewsIndustries Software development

Question

Review this Java HTTP client used for all calls to a third-party API. Occasionally threads pile up and the request pool exhausts.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1@Configuration2class HttpConfig {3    @Bean4    RestTemplate client() {5        SimpleClientHttpRequestFactory f = new SimpleClientHttpRequestFactory();6        f.setConnectTimeout(2000);7        return new RestTemplate(f);8    }9}10 11@Service12class PartnerClient {13    private final RestTemplate client;14    PartnerClient(RestTemplate client) { this.client = client; }15 16    Quote getQuote(String sku) {17        return client.getForObject("https://partner.example/q/" + sku, Quote.class);18    }19}

Run or narrate your approach, then ask the coach.