Request threads pile up
Review this Java HTTP client used for all calls to a third-party API. Occasionally threads pile up and the request pool exhausts.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1@Configuration
2class HttpConfig {
3 @Bean
4 RestTemplate client() {
5 SimpleClientHttpRequestFactory f = new SimpleClientHttpRequestFactory();
6 f.setConnectTimeout(2000);
7 return new RestTemplate(f);
8 }
9}
10
11@Service
12class PartnerClient {
13 private final RestTemplate client;
14 PartnerClient(RestTemplate client) { this.client = client; }
15
16 Quote getQuote(String sku) {
17 return client.getForObject("https://partner.example/q/" + sku, Quote.class);
18 }
19}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.