Code RoomFetch timeout leaves promise pending

MediumPrep Room Coding #1944

Fetch timeout leaves promise pending

Code reviewCode quality & reviewMid–Senior~18 min

Review this JavaScript wrapper that races a fetch against a timeout.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1function fetchWithTimeout(url, ms) {

2 return Promise.race([

3 fetch(url),

4 new Promise((_, reject) =>

5 setTimeout(() => reject(new Error("timeout")), ms)

6 ),

7 ]);

8}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.