Code reviewMediumcr-g311

Subject Timeout handlingLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this JavaScript wrapper that races a fetch against a timeout.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1function fetchWithTimeout(url, ms) {2  return Promise.race([3    fetch(url),4    new Promise((_, reject) =>5      setTimeout(() => reject(new Error("timeout")), ms)6    ),7  ]);8}

Run or narrate your approach, then ask the coach.