Code RoomCircuit breaker never closes

MediumPrep Room Coding #1946

Circuit breaker never closes

Code reviewCode quality & reviewMid–Senior~18 min

Review this Python breaker that guards a downstream and counts failures to decide when to open.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1def call(self, fn, *args):

2 if self.open and time.time() - self.opened_at < self.cooldown:

3 raise CircuitOpen()

4 try:

5 return fn(*args)

6 except Exception:

7 self.failures += 1

8 if self.failures >= self.threshold:

9 self.open = True

10 self.opened_at = time.time()

11 raise

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.