Code reviewMediumcr-g313

Subject Circuit breakerLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python breaker that guards a downstream and counts failures to decide when to open.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def call(self, fn, *args):2    if self.open and time.time() - self.opened_at < self.cooldown:3        raise CircuitOpen()4    try:5        return fn(*args)6    except Exception:7        self.failures += 18        if self.failures >= self.threshold:9            self.open = True10            self.opened_at = time.time()11        raise

Run or narrate your approach, then ask the coach.