Code reviewHardcr-g314

Subject Swallowed exceptionsLevel Senior–Staff~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python function that records a sale: it writes the ledger entry, then updates inventory.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def record_sale(conn, sku, qty, amount):2    cur = conn.cursor()3    cur.execute("INSERT INTO ledger (sku, amount) VALUES (%s, %s)", (sku, amount))4    try:5        cur.execute("UPDATE inventory SET qty = qty - %s WHERE sku = %s", (qty, sku))6    except Exception as e:7        logging.warning("inventory update failed: %s", e)8    conn.commit()9    return "ok"

Run or narrate your approach, then ask the coach.