Code reviewMediumcr-g316

Subject Swallowed exceptionsLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this JavaScript request handler that returns immediately and does the slow reindex work in the background.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1async function reindex(docId) {2  const doc = await store.fetch(docId);      // may reject3  await searchClient.index(doc);             // may reject / time out4}5 6app.post("/reindex", (req, res) => {7  const { docId } = req.body;8  if (!docId) {9    return res.status(400).json({ error: "docId required" });10  }11  res.status(202).json({ status: "queued" });12  reindex(docId).then(() => {13    metrics.inc("reindex.ok");14  });15});

Run or narrate your approach, then ask the coach.