Code reviewHardcr-g318

Subject Missing rollbackLevel Senior–Staff~22 minCommon in Databases & SQL · Reliability & on-call interviewsIndustries Software development, Technology

Question

Review this Java booking method that charges the customer, then persists the reservation.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1@Transactional2public Booking book(BookingReq req) {3    Charge c = paymentGateway.charge(req.getCardToken(), req.getAmount()); // external API4    Booking b = new Booking(req, c.getId());5    bookingRepo.save(b);   // may throw on constraint violation6    inventory.decrement(req.getRoomId()); // local DB7    return b;8}

Run or narrate your approach, then ask the coach.