Code reviewMediumcr-g319

Subject Partial failureLevel Mid–Senior~18 minCommon in Distributed systems interviewsIndustries Software development

Question

Review this Python function that fans out a notification to many recipients. `send` calls an email provider and may raise on a single bad address or a transient error.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def send(recipient, message):2    resp = provider.send_email(to=recipient, body=message)3    resp.raise_for_status()   # raises on 4xx/5xx4 5def notify_all(recipients, message):6    sent = 07    for r in recipients:8        send(r, message)9        sent += 110    logging.info("notified %d recipients", sent)11    return sent

Run or narrate your approach, then ask the coach.