Code reviewMediumcr-g320

Subject Partial failureLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this JavaScript code that writes a record to three downstream services in parallel and reports success.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1async function syncRecord(rec) {2  await Promise.all([3    crm.upsert(rec),4    search.index(rec),5    cache.set(rec.id, rec),6  ]);7  return { synced: true };8}

Run or narrate your approach, then ask the coach.