Code RoomLoad error discarded silently
MediumPrep Room Coding #1954

Load error discarded silently

Code reviewCode quality & reviewMid–Senior~18 min

Review this Go cache-population helper. `cache.Get` returns `(value, found bool)`; `db.Load` returns `(value, error)`.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1func getConfig(key string) string {
2 if v, ok := cache.Get(key); ok {
3 return v
4 }
5 v, _ := db.Load(key)
6 cache.Set(key, v)
7 return v
8}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.