Code reviewHardcr-g327

Subject Date arithmeticLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python code that converts a logged local timestamp to UTC for storage (drivers log in their local zone).

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1from datetime import datetime2from zoneinfo import ZoneInfo3 4def to_utc(local_str, tzname):5    # local_str like '2026-11-01 01:30:00', tzname like 'America/New_York'6    naive = datetime.strptime(local_str, '%Y-%m-%d %H:%M:%S')7    return naive.replace(tzinfo=ZoneInfo(tzname)).astimezone(ZoneInfo('UTC'))

Run or narrate your approach, then ask the coach.