Code reviewMediumcr-g328

Subject Money roundingLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java method that sums an order's line totals (each a dollar amount) and compares to the charged amount before settling.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1boolean reconciles(List<Double> lineTotals, double charged) {2    double sum = 0.0;3    for (double t : lineTotals) {4        sum += t;            // dollars, e.g. [0.10, 0.20]5    }6    if (sum == charged) {    // charged also a dollar double, e.g. 0.307        log.info("order reconciled: {}", sum);8        return true;9    }10    log.warn("mismatch: sum={} charged={}", sum, charged);11    return false;12}

Run or narrate your approach, then ask the coach.