Code reviewMediumcr-g332

Subject Data bugsLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java code computing a per-seller average rating to display on a dashboard.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1double avgRating(List<Integer> ratings) {2    int sum = 0;3    for (Integer r : ratings) {4        sum += r;            // ratings may contain null for 'no score'5    }6    return (double) sum / ratings.size();7}

Run or narrate your approach, then ask the coach.