Code reviewHardcr-g338

Subject Floating pointLevel Senior–Staff~20 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this Java that sorts search results by a computed relevance score (descending) before paginating.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1List<Result> ranked(List<Result> results) {2    results.sort((a, b) -> {3        double sa = a.score();   // NaN when no signals fired4        double sb = b.score();5        if (sa < sb) {6            return 1;            // b ranks higher7        }8        if (sa > sb) {9            return -1;           // a ranks higher10        }11        return 0;12    });13    return results.subList(0, Math.min(20, results.size()));14}

Run or narrate your approach, then ask the coach.