Code reviewMediumcr-g340

Subject EncodingLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java that reads an uploaded CSV's bytes, parses the header row, and maps each declared column to its index.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1Map<String, Integer> headerIndex(byte[] csvBytes) {2    String text = new String(csvBytes);    // file is UTF-83    String firstLine = text.split("\n", 2)[0];4    String[] cols = firstLine.split(",");5    Map<String, Integer> index = new HashMap<>();6    for (int i = 0; i < cols.length; i++) {7        index.put(cols[i].trim(), i);      // e.g. "Pr\u00e9nom" -> 08    }9    return index;10}

Run or narrate your approach, then ask the coach.