Code reviewHardcr-g347

Subject Backward compatibilityLevel Senior–Staff~25 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this TypeScript serializer change to a public v1 order API. The `total` field used to be a number; a teammate switched it to a formatted string to display currency.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewtypescript

1// before:  return { id: o.id, total: o.totalCents / 100 }2function serializeOrder(o: Order) {3  return {4    id: o.id,5    status: o.status,6    total: formatCurrency(o.totalCents, o.currency), // "$42.00"7    currency: o.currency,8  };9}10 11function formatCurrency(cents: number, ccy: string): string {12  return new Intl.NumberFormat('en-US', {13    style: 'currency', currency: ccy,14  }).format(cents / 100);15}

Run or narrate your approach, then ask the coach.