Code RoomOffset pagination skips rows

HardPrep Room Coding #1977

Offset pagination skips rows

Code reviewNetworking & APIsConcurrencySenior–Staff~25 min

Review this Python offset-pagination endpoint for an activity feed that receives frequent inserts at the top.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 25 min

Mark a line and say what kind of problem it is.0 findings

1@app.get('/api/feed')

2def feed():

3 page = int(request.args.get('page', 1))

4 size = 20

5 offset = (page - 1) * size

6 items = db.execute(

7 'SELECT id, body, created_at FROM activity '

8 'ORDER BY created_at DESC LIMIT %s OFFSET %s',

9 (size, offset),

10 ).fetchall()

11 return jsonify({'page': page, 'items': [dict(i) for i in items]})

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.