Code reviewHardcr-g351

Subject Contract violationsLevel Senior–Staff~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this TypeScript handler for `PATCH /users/:id` that updates a user profile.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewtypescript

1app.patch('/users/:id', async (req, res) => {2  const body = req.body as Partial<UserProfile>;3  const updated: UserProfile = {4    name: body.name,5    email: body.email,6    bio: body.bio,7    phone: body.phone,8    notifications: body.notifications,9  };10  await db.users.replace(req.params.id, updated);11  res.json(updated);12});

Run or narrate your approach, then ask the coach.