Code reviewHardcr-g356

Subject Leaky abstractionsLevel Senior–Staff~25 minCommon in Networking & APIs interviewsIndustries Software development, Technology

Question

Review this Go API that returns a pagination cursor to clients.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1type Page struct {2    Items      []Doc  `json:"items"`3    NextCursor string `json:"next_cursor"`4}5 6func listDocs(w http.ResponseWriter, r *http.Request) {7    cur := r.URL.Query().Get("cursor") // raw DB offset, e.g. "40"8    offset, _ := strconv.Atoi(cur)9    docs := repo.Find(offset, 20)      // SELECT ... OFFSET ?10    next := strconv.Itoa(offset + 20)11    json.NewEncoder(w).Encode(Page{Items: docs, NextCursor: next})12}

Run or narrate your approach, then ask the coach.