Code reviewMediumcr-g358

Subject Contract violationsLevel Mid–Senior~20 minCommon in Networking & APIs interviewsIndustries Software development, Technology

Question

Review this Go HTTP handler exposed at `GET /reports/:id/export`.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func exportReport(w http.ResponseWriter, r *http.Request) {2    id := chi.URLParam(r, "id")3    report := repo.Get(id)4    file := renderPDF(report)         // heavy, ~3s5    repo.IncrementExportCount(id)     // writes to DB6    audit.Log("export", id)           // side effect7    w.Header().Set("Content-Type", "application/pdf")8    w.Write(file)9}

Run or narrate your approach, then ask the coach.